Slip mode: consider loop for background position only if it was enabled before slip #11848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed before slip this restores 2.3 behaviour (broken by c5127eb): * enable slip mode (no active loop) * active loop (NOT rolling loop since that would quit slip mode when disabling it) * let it do a few interations so the slip position and the background position can be clearly distinguished * disable loop * quit slip mode = position is where it would have been without slip mode
|
We could also add a test for this situation. |
|
This fixes the bug! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores 2.3 behaviour (broken by c5127eb):
Closes #11844
@JoergAtGithub please test!